Probably easiest to look at the preview for review…

@nbroyles Should this also be removed?

@nbroyles Should this also be removed?

m3/site/content/includes/m3query/annotated_config.yaml

Lines 64 to 67 in 3113451

	clusters:
	- namespaces:
	- namespace: default
	type: unaggregated

Yup. You can also remove this:

Codecov Report

Merging #3324 (ab8fedd) into master (1843061) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3324     +/-   ##
=========================================
- Coverage    72.4%    72.4%   -0.1%     
=========================================
  Files        1100     1100             
  Lines      102443   102443             
=========================================
- Hits        74190    74187      -3     
+ Misses      23155    23153      -2     
- Partials     5098     5103      +5     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1843061...ab8fedd. Read the comment docs.

Ready for a final review @robskillington and also bringing in @wesleyk here for some input… A couple of notes after many conversations with Rob…

The m3dbnode config is pretty solid and mostly understandable. The M3 Query/Coordinator config isn't, and is still quite confusing, mostly as there seem some discrepancies between the way config works between m3dbnode setups and separated node clusters.

This is something that need resolving in the code base but also docs changes from here on in at a higher level will attempt to clarify the differences in context of implementation.

Overall I think this is looking really good.

I do have one major concern though having reviewed the documentation preview a few times, I think that "Architecture" is now really hard to find. You don't really expect to have "Architecture" under "Reference".

I believe actually it would be more discoverable/obvious if we did the following and split them and make them separate top level entries "Reference & Config" (to make it obvious to find config file explanations here) and "Architecture":

Reference & Config
- M3DB
 - Configuration file
- M3 Coordinator
 - API
 - Configuration file
- M3 Query
 - API
 - Configuration file

Architecture
- M3DB
 - Storage Engine
 - Sharding
 - Consistency Levels
 - Storage
 - Commit Logs And Snapshot Files
 - Peer Streaming
 - Caching
- M3 Coordinator
 - Overview
- M3 Query
 - Overview